[entsoe] Refactor HTTP error handling #17616
Open
+101
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <[email protected]>
|
@kaikreuzer - can you add @jmelhus to the contributor team, so he will be added as reviewer for ENTSO-E pull requests? He is our new binding maintainer. 🙂 |
|
Sure thing - done! Welcome @jmelhus 😄 |
|
He is invited and needs to accept the invitation before you can see him there. |
Ah, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary objective of this pull request is to improve handling of HTTP error code 401 ("Unauthorized") by eliminating exception message string comparison - see #17416 (comment).
Additionally, we will now provide "openHAB" with version number in the
User-Agentheader. This will make it possible to reach out to us in case of any issues.And last, but not least,
InterruptedExceptionwill no longer be swallowed byHttpUtiland rethrown asIOException. This allows us rethrowInterruptedExceptionall the way up the call chain. This will ensure that the thread interruption request is respected immediately, rather than masking the exception by catching it prematurely.